fix: restore the sidebar position to make the selected entry showed #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
imfing
requested changes
Nov 3, 2024
assets/js/sidebar.js
Outdated
| } | ||
|
|
||
| sidebarScrollbar.addEventListener('scroll', function() { | ||
| saveSidebarPosition(); |
There was a problem hiding this comment.
I think you need debouncing the event handler.
|
To be honest, I don't know how Vitepress is implemented, I'm just referring to the effects. |
update the theme 241104
|
There’s an issue after this change: switching between sidebar items would cause a noticeable jittering effect every time. Screenshot.2024-11-07.at.12.48.02.mp4Previous: Screenshot.2024-11-07.at.12.49.04.mp4 |
|
I've noticed this issue, but I've been struggling to figure out how to fix it. After testing, it is now possible to significantly reduce the frequency of occurrences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save and restore the sidebar position to make the selected entry showed. #490