feat: support theme toggle in navbar. #499
Conversation
- Add additional logic for navbar partial. - Uses a menu item params.type of `theme-toggle`. - Uses additional params.hideLabel boolean to set hideLabel for the theme-toggle.html partial.
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This isn't a perfect PR, as I didn't include any updates to documentation for this feature and instead focused on implementation. I figured if this looks good, I could add documentation changes to this PR. :) |
- Add navbar boolean to theme-toggle partial arguments. - Add logic in theme-toggle to set icon size based on navbar boolean.
|
Gave theme-toggle partial logic based on navbar boolean, to set size of icon based on navbar or elsewhere. This does not address the size of the toggle's label. I see the |
|
Put logic in theme-toggle when in navbar to match size of navbar text. |
| {{- $height_px := 12 -}} | ||
| {{- $height_tw := "hx-text-xs" -}} | ||
| {{- if $navbar -}} | ||
| {{- $height_px = 24 -}} | ||
| {{- $height_tw = "hx-text-sm" -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
just curious where are 12 and 24 coming from?
There was a problem hiding this comment.
Great question! I've been offline for a few weeks, and honestly, I'd have to say it is likely a best estimate based on testing that made things look "right."
If those values can be computed from other inputs in the theme configuration, I'm certainly willing to explore that. Do you have any guidance on how we might calculate a sane value for this?
imfing
changed the title
theme-toggle.Addresses #343 .