-
-
Notifications
You must be signed in to change notification settings - Fork 364
enhance: Refactor static icons to static/icons directory for cleaner public directory #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
imfing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using "favicons" instead of "icons," which sounds more specific?
|
Sure, I can do that. Do you want me to proceed with that change? |
go ahead, please also resolve the merge conflicts |
|
@smit-io do you plan to work on this or should I close it? |
|
Yes. I will make the changes soon. |
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
changes are done |
Please resolve the conflicts |
|
Done |
static/favicons/favicon-dark.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been moved to docs site, please remove it
|
I have removed it, anything else I am missing? |
moved png, ico and svg to static/favicons so the icons are not in the root directory in public/.
Directory structure is a bit better.
Files moved (from static to static/favicons):
Before
After