Skip to content

fix: disable nav tag for toc when toc is disabled #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KStocky wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: disable nav tag for toc when toc is disabled #749

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4addbd8
fix: disable nav tag for toc when toc is disabled
KStocky Aug 14, 2025
6854727
feat: Make disabling of the right side bar be controlled by a new par…
KStocky Aug 14, 2025
75ae48b
Remove erroneous closing nav tag
KStocky Aug 14, 2025
205738d
Merge branch 'main' into FullyDisableTocWhenRequested
KStocky Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions layouts/_partials/toc.html
View file
Open in desktop
Copy link
Contributor Author

@KStocky KStocky Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding whitespace will make this diff a lot clearer

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
{{- $editThisPage := (T "editThisPage") | default "Edit this page"}}
{{- $backToTop := (T "backToTop") | default "Scroll to top" -}}

<nav class="hextra-toc hx:order-last hx:hidden hx:w-64 hx:shrink-0 hx:xl:block hx:print:hidden hx:px-4" aria-label="table of contents">
{{- if $toc }}
{{- if $toc }}
<nav class="hextra-toc hx:order-last hx:hidden hx:w-64 hx:shrink-0 hx:xl:block hx:print:hidden hx:px-4" aria-label="table of contents">
<div class="hextra-scrollbar hx:sticky hx:top-16 hx:overflow-y-auto hx:pr-4 hx:pt-6 hx:text-sm [hyphens:auto] hx:max-h-[calc(100vh-var(--navbar-height)-env(safe-area-inset-bottom))] hx:ltr:-mr-4 hx:rtl:-ml-4">
{{- with .Fragments.Headings -}}
<p class="hx:mb-4 hx:font-semibold hx:tracking-tight">{{ $onThisPage }}</p>
Expand Down Expand Up @@ -61,8 +61,8 @@
</button>
</div>
</div>
{{ end -}}
</nav>
</nav>
{{ end -}}

{{/* TOC subheadings component. This is a recursive component that renders a list of headings. */}}
{{- define "toc-subheading" -}}
Expand Down