Skip to content

feat(codeblock): add full URL support #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −1
Open

feat(codeblock): add full URL support #820

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb9f9dd
add-full-url-support
wharris23 Sep 3, 2025
1310fb4
Fix code block template to safely handle full_url
wharris23 Sep 3, 2025
62be9cd
Update layouts/_partials/components/codeblock.html
wharris23 Sep 10, 2025
bb7121a
Merge branch 'main' into add-full-url-support
wharris23 Sep 10, 2025
49f4ed1
Update layouts/_partials/components/codeblock.html
wharris23 Sep 11, 2025
39bf711
Merge branch 'main' into add-full-url-support
wharris23 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion layouts/_partials/components/codeblock.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@

{{- $base_url = strings.TrimSuffix "/" $base_url -}}
{{- $filename = strings.TrimPrefix "/" $filename -}}
{{- $file_url := urls.JoinPath $base_url $filename -}}

{{- $file_url := $filename -}} <!-- default to just filename -->

{{- if .full_url -}}
Copy link
Owner

@imfing imfing Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full_url is ignored when $base_url is empty, please pay attention to line 9

{{- $file_url = .full_url -}}
{{- else if $base_url -}}
{{- $file_url = urls.JoinPath $base_url $filename -}}
{{- end -}}


<a class="hx:no-underline hx:inline-flex hx:items-center hx:gap-1" href="{{ $file_url }}" target="_blank" rel="noopener noreferrer">
<span>{{- $filename -}}</span>
Expand Down