Stripping HAHAHUGOSHORTCODExxxx in toc.html when icons are used in headings
#854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
This should fix Issue #849 |
Author
|
@imfing kindly review and provide any quick feedback. |
imfing
reviewed
Oct 7, 2025
| <li class="hx:my-2 hx:scroll-my-6 hx:scroll-py-6"> | ||
| <a class="{{ $class }} hx:inline-block hx:text-gray-500 hx:hover:text-gray-900 hx:dark:text-gray-400 hx:dark:hover:text-gray-300 hx:contrast-more:text-gray-900 hx:contrast-more:underline hx:contrast-more:dark:text-gray-50 hx:w-full hx:break-words" href="#{{ anchorize .ID }}"> | ||
| {{- .Title | safeHTML | plainify | htmlUnescape }} | ||
| {{- replaceRE "HAHAHUGOSHORTCODE[0-9a-zA-Z]+HBHB" "" (.Title | safeHTML | plainify | htmlUnescape) }}gi |
imfing
reviewed
Oct 7, 2025
Owner
imfing
left a comment
imfing
left a comment
There was a problem hiding this comment.
IMO, this approach relies on internal Hugo heuristics and string patterns that aren’t part of the public API. If Hugo changes its implementation or the shortcode prefix slightly, this workaround could easily break
The recommended way is to avoid including shortcodes (or any HTML) directly in headings in the first place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very quick fix to remove icon shortcodes from rendering as
HAHAHUGOSHORTCODExxxxon the table of contents on the right hand side of the page. This PR should temporarily strip this until a better solution to actually render the icon properly is devised.The fix itself uses
replaceREto sanitize the output and strip out the prefix.