fix(navbar): navbar on small screen now follow menu.main from hugo.yaml #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added detection in the sidebar partial for cases where the sidebar is also used as a navbar, i.e., in mobile view.
This workaround use "IsHome" from context. It fix #240 (comment) and partialy #265 (comment)
This workaround isn’t elegant. It would be better to create a new partial,
side-navbar.html, that relies onsidebar.html. This would allow crawling through menu.main inhugo.yamland discovering the subfolders under each section based on each menu path. (Handling nested menus is still an open question.) This refactor will allow to easily fix #497 (comment), #831 (comment) and #449 (comment) by getting weight and name fromhugo.yaml