Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination improvements #31

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Pagination improvements #31

wants to merge 8 commits into from

Conversation

ohadschn
Copy link
Contributor

The first commit converts the pages observable to an array for a better binding experience, and adds a limitedPages observable array that is constrained to contain only paginationLimit pages as per #22.

The second commit adds a blanks array to each page in the pages observable array introduced above whose length is the amount of elements for that page that are missing for it to have perPage elements (i.e. 0 for all pages except the last one, for which it equals perPage-[pageElementCount]). The view can then bind to it in order to complete these missing entries and avoid the annoying table resize jumps when switching to and from it.

@ohadschn
Copy link
Contributor Author

@cbankester Just in case you missed this :)

@cmbankester
Copy link
Contributor

@ohadschn I like what you did here! I never would have thought to include empty row slots in DataTable, but that really makes sense. I'm going to do a code review and then we can get it merged in.

@ohadschn
Copy link
Contributor Author

I admit, that was a little hackish but you can't argue with the result :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants