-
Notifications
You must be signed in to change notification settings - Fork 15
Introduce ability to start and stop depth processing #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a bit weird. I don't think we have logic in WebXR that triggers by setting a boolean. |
We don't have a boolean, but we do have a float that functions very similarly: https://immersive-web.github.io/webxr/#dom-xrwebgllayer-fixedfoveation I think there was some opposition to adding it to the renderState. Mainly @toji IIRC? The original proposal was a pair of methods; but I felt that this was more elegant since calling the start/stop methods didn't necessarily guarantee anything. |
@cabanier I've shifted away from the attribute. |
Introduces the `depthActive` property to allow pages to request starting or stopping the depth activity.
4e00931
to
d18cae6
Compare
/agenda discuss options to start/stop depth sensing Since the in-comment-thread tag didn't seem to flag it. |
Thanks, interesting that probot doesn't get the comment events from inline code discussions. |
I did make one rename here from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! One minor comment.
@bialpio I'll merge tomorrow AM unless you provide additional feedback. |
SHA: 76ce48f Reason: push, by alcooper91 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Introduces the
depthActive
property to allow pages to request starting or stopping the depth activity.Addresses #52
Preview | Diff