Skip to content

add menu button to Quest/Oculus controllers #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

add menu button to Quest/Oculus controllers #259

merged 1 commit into from
Jun 10, 2024

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Jun 7, 2024

An upcoming version of the Quest browser will no longer exit WebXR when the menu button is clicked.
This will enable us to add support for this button to controllers and hands.

@cabanier cabanier requested review from toji and felixtrz June 7, 2024 21:42
@AdaRoseCannon
Copy link
Member

Will there still be a system button to ext an XR session?

@cabanier
Copy link
Member Author

cabanier commented Jun 7, 2024

Will there still be a system button to ext an XR session?

The Quest/Oculus button will still bring up trusted UI.

Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for clarifying about the trusted UI!

@toji toji merged commit 99baa41 into main Jun 10, 2024
1 check passed
@toji toji deleted the menu-button branch June 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants