Skip to content

Add generic-fixed-hand registry entry #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add generic-fixed-hand registry entry #261

merged 2 commits into from
Jun 13, 2024

Conversation

toji
Copy link
Member

@toji toji commented Jun 12, 2024

Only adds the registry entry, not an associated asset. That will be handled in a follow up.

Last call for bikeshedding! 😆

@@ -0,0 +1,32 @@
{
"profileId" : "generic-fixed-hand",
"fallbackProfileIds": ["generic-hand", "generic-hand-select"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fall back to generic-trigger instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I could see an argument for it either way. Curious what others think, especially @AdaRoseCannon.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic-trigger IIUC falls back to being basically a controller?

Copy link
Member

@cabanier cabanier Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Falling back to generic-hand would be strange since it won't draw correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping generic-hand-select in the profiles array, since it's an accurate description of the input and doesn't have an associated asset?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds good to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping generic-hand-select in the profiles array, since it's an accurate description of the input and doesn't have an associated asset?

Yeah that makes sense, to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! Updated the profile list to ['generic-fixed-hand', 'generic-hand-select', 'generic-trigger'], which was my sense of the best "Most specific->Least Specific" progression.

@toji toji merged commit 80f38e3 into main Jun 13, 2024
1 check passed
@toji toji deleted the generic-fixed-hand branch June 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants