-
Notifications
You must be signed in to change notification settings - Fork 55
Add generic-fixed-hand registry entry #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,32 @@ | |||
{ | |||
"profileId" : "generic-fixed-hand", | |||
"fallbackProfileIds": ["generic-hand", "generic-hand-select"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we fall back to generic-trigger
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... I could see an argument for it either way. Curious what others think, especially @AdaRoseCannon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generic-trigger IIUC falls back to being basically a controller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. Falling back to generic-hand would be strange since it won't draw correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about keeping generic-hand-select
in the profiles array, since it's an accurate description of the input and doesn't have an associated asset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about keeping
generic-hand-select
in the profiles array, since it's an accurate description of the input and doesn't have an associated asset?
Yeah that makes sense, to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! Updated the profile list to ['generic-fixed-hand', 'generic-hand-select', 'generic-trigger']
, which was my sense of the best "Most specific->Least Specific" progression.
Only adds the registry entry, not an associated asset. That will be handled in a follow up.
Last call for bikeshedding! 😆