-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (web): panorama / 360 view - partial panorama: use photo-sphere-viewer #6992
Conversation
web/src/lib/components/asset-viewer/photo-sphere-viewer-adapter.svelte
Outdated
Show resolved
Hide resolved
@danieldietzler could you help me to merge this PR? |
I don't merge PRs, only some people do :) |
No urgency, just wanted not to forget about this :) |
We usually don't "forget" pull requests, no worries. |
The photo-sphere-viewer documentation says that it handles cropped/partial panoramas by looking at image metadata. We strip most metadata from preview images now, so can you confirm that a newly uploaded partial panorama still works? |
@mertalev tested on panorama taken on iPhone and it works |
Yep, I also tested on newly uploaded images. As far as I see, exif is not removed from image |
@dmitry-brazhenko I think panorama-viewer.css is now unused, isn't it? Then I guess it should be deleted. |
A few comments...
|
That's good point. I created an issue: #7243 |
Previous PR: #3412
This PR should fix 2 issues: #3490 and #3465
I changed 360 images viewer. Now I use photo-sphere-viewer.
I checked "cropped/partial" panoramas and they work fine.