Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added type to attributes property of Recipient #51

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

antonioturdo
Copy link
Collaborator

🚨 Proposed changes

Let's add an allowed type to the attributes property of Recipient, so we can use the UserAttributes object directly.
In the future we may remove the array type for better typing.

⚙️ Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Refactor

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a1f58e) 99.57% compared to head (d303152) 99.57%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #51   +/-   ##
=========================================
  Coverage     99.57%   99.57%           
  Complexity      494      494           
=========================================
  Files           139      139           
  Lines           939      939           
=========================================
  Hits            935      935           
  Misses            4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antonioturdo antonioturdo merged commit 5edf031 into main Dec 19, 2023
10 checks passed
@antonioturdo antonioturdo deleted the fix/recipient-attributes-type branch December 19, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants