Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @immobiliare/dats to 5.1.0 #613

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore(deps): bump @immobiliare/dats to 5.1.0 #613

merged 1 commit into from
Jun 3, 2024

Conversation

ryanrishi
Copy link
Contributor

🚨 Proposed changes

Please review the guidelines for contributing to this repository.

Pull in changes from immobiliare/dats#922

Also noticed that package-lock.json and yarn.lock are in .gitignore— it's best practice to commit those files (per npm, yarn) so that builds are consistent and reliable.

⚙️ Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Refactor

@simonecorsi
Copy link
Collaborator

Hi @ryanrishi, can you please amend the commit to use conventional commit convention please? :)

Copy link
Contributor

@dnlup dnlup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ryanrishi for this. We have an issue with the @tapjs/sinon plugin , let's wait a bit to see if it gets fixed so the the tests will start working again.

@dnlup
Copy link
Contributor

dnlup commented May 29, 2024

Also noticed that package-lock.json and yarn.lock are in .gitignore— it's best practice to commit those files (per npm, yarn) so that builds are consistent and reliable.

We decided to remove the lock file because a few Node majors ago those files had different version between Node version (because the shipped npm had different major versions) and that caused issues. Since lock files are ignored when a package it's installed as a lib, like this plugin is, we opted to live with the fact the local builds do not use a lock.

@dnlup
Copy link
Contributor

dnlup commented May 31, 2024

@ryanrishi I managed to fix test errors and merged the fix, if you could change the commit message we would merge this and publish a new release 😉

@ryanrishi
Copy link
Contributor Author

@ryanrishi I managed to fix test errors and merged the fix, if you could change the commit message we would merge this and publish a new release 😉

Nice, thanks! Updated the commit message ✅

@dnlup dnlup merged commit d1386bf into immobiliare:main Jun 3, 2024
1 check passed
@simonecorsi
Copy link
Collaborator

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ryanrishi ryanrishi deleted the bump-dats-version branch June 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants