Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sdgtarget features #421

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

lukearndt
Copy link
Collaborator

@lukearndt lukearndt commented Oct 15, 2024

Context

#363

We don't need the SDG Target features so we want to delete them

Changes

This commit deletes the SDG Target features from the application. This
includes the following tables and all of their corresponding
associations, controllers, factories, models, policies, routes,
serializers, and specs:

  • sdgtarget_categories
  • sdgtarget_indicators
  • sdgtarget_measures
  • sdgtarget_recommendations
  • sdgtargets

It does not delete the groups_sdgtargets_default field from the
Taxonomy model.

Considerations

The database migration that removes the tables is reversible, with the
following caveats:

  1. It recreates the dropped tables using the statements in schema.rb,
    which were taken from the version in nz-justice-development at the
    time of this commit. Right now, there aren't any pending PRs that alter
    those table definitions so they should be correct, but that could change
    between the creation and merging of this PR.

  2. Rolling back the migration will restore the tables, but it will not
    restore any of their previous data. That data will only be recoverable
    if we take and retain a database backup prior to deploying this change.

@tmfrnz tmfrnz changed the title Delete sdgtarget features from NZ Justice variant Delete sdgtarget features Dec 12, 2024
@tmfrnz tmfrnz merged commit 8e49490 into nz-justice-development Dec 12, 2024
2 checks passed
@tmfrnz tmfrnz deleted the 363-delete-sdgtarget-features branch December 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants