Tweaks to table row matching with numerics #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@schusslern I remember we talked about this being an issue and I created this merge request. I cannot remember why I did not merge this. I assume this is something you want? |
|
It looks like Age Dx on the staging API. Age is supposed to be a whole number.
But I don’t remember why it would have been an issue – sorry ☹
I did look at the TNM squish and don’t see an issue related to age and decimal.
It seems like a good thing to have
Nicki
From: Chuck May ***@***.***>
Sent: Friday, May 23, 2025 9:19 AM
To: imsweb/staging-client-java ***@***.***>
Cc: Schussler, Nicola (IMS) ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [imsweb/staging-client-java] Tweaks to table row matching with numerics (PR #113)
[Image removed by sender.]ctmay4 left a comment (imsweb/staging-client-java#113)<#113 (comment)>
@schusslern<https://github.com/schusslern> I remember we talked about this being an issue and I created this merge request. I cannot remember why I did not merge this. I assume this is something you want?
—
Reply to this email directly, view it on GitHub<#113 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7CQP4PPGVVSJ5BNQOW4TD274N3VAVCNFSM6AAAAABVTFLHIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBUGM4TSOBUGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
…________________________________
Information in this e-mail may be confidential. It is intended only for the addressee(s) identified above. If you are not the addressee(s), or an employee or agent of the addressee(s), please note that any dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender of the error.
|
|
Sounds good. I just wanted to make sure this was not going to break something you were relying on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching table rows, we are using a float comparison for ranges. That means that we can find a match for a decimal value for a purely integer range. That is not what was intended.
For example, if a table had a row defined like this:
If you tried to match "35.5" it would find a match because it was just doing a float compare between "0" and "120". However since that is not a decimal comparison it should not have found a match. This issue changes so that if neither the high or low value have a decimal point and the value it is using to compare does, then it will not find a match. So "35.5" would not find a match.