Add KubeCon + CloudNativeCon NA '23 demo files #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcela Melara <[email protected]>
marcelamelara
requested review from
adityasaky,
pxp928 and
SantiagoTorres
as code owners
marcelamelara
force-pushed
the
add-kubecon-demo-files
branch
from
5dde4e9
to
ce5b2fb
Compare
Signed-off-by: Marcela Melara <[email protected]>
marcelamelara
force-pushed
the
add-kubecon-demo-files
branch
from
66426d7
to
9e89fcd
Compare
adityasaky
reviewed
Jan 16, 2024
scai-gen/cmd/rekor.go
Outdated
| } | ||
|
|
||
| fileScanner := bufio.NewScanner(readFile) | ||
| fileScanner.Split(bufio.ScanLines) |
There was a problem hiding this comment.
Is this needed? This is the default, right?
Split sets the split function for the Scanner. The default split function is ScanLines.
scai-gen/cmd/rekor.go
Outdated
| return fmt.Errorf("error decoding base64-encoded public key: %w", err) | ||
| } | ||
|
|
||
| // dedup |
There was a problem hiding this comment.
Could you clarify this comment?
scai-gen/cmd/rekor.go
Outdated
| for _, line := range fileLines { | ||
| lineStr := string(line) | ||
| if strings.Contains(lineStr, "publicKey") { | ||
| pkB64Raw := strings.TrimPrefix(lineStr, " \"publicKey\": ") |
There was a problem hiding this comment.
strings.TrimSpace to make this more robust in case the output changes slightly?
scai-gen/cmd/rekor.go
Outdated
|
|
||
| for _, line := range fileLines { | ||
| lineStr := string(line) | ||
| if strings.Contains(lineStr, "publicKey") { |
There was a problem hiding this comment.
I think strings.HasPrefix may be better after TrimSpace.
|
Thanks for your comments @adityasaky . I'm actually going to remove all of the Rekor related code since it's experimental and not included in the actual demo. |
Signed-off-by: Marcela Melara <[email protected]>
adityasaky
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a dedicated directory that contains all of the files and documentation used in the demo showed at Kubecon + CloudNativeCon `23.