Refactor SCAI generator APIs into pkg/ #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcela Melara <[email protected]>
marcelamelara
requested review from
adityasaky,
pxp928 and
SantiagoTorres
as code owners
adityasaky
reviewed
Feb 23, 2024
Yes, and I want to separate the CLI from the underlying SCAI "attestor" APIs and have those be importable independently. |
Signed-off-by: Marcela Melara <[email protected]>
|
@alanssitis ptal! |
alanssitis
approved these changes
Mar 3, 2024
|
Should we add @alanssitis as a maintainer? Also, totally agree that scai-gen should eventually be moved out of this repo, and probably into go-witness as part of the broader in-toto golang consolidation efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the core SCAI predicate generator APIs into
pkg/for external usage outside the CLI.An anticipated usage of these refactored APIs will be in the build image attestation PoC for the SLSA workstream on Hardware Attested Platforms.
This also fixes a couple of related documentation bugs.