Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
During verification there is nondeterministic behavior if the flag
--verifier-kms-aws-remote-verify=[true/false]
is not specified. I found that this is because there is an early return causing the default booleantrue
value to not be set for theverifyRemotely
attribute.In some instances, the first
ksp
in the outer loop will bekms-gcp
. If using an AWS reference, then the proper verifyRemotely setter will not be run. Other times, the firstksp
will bekms-aws
and the proper setter will be called.You can check this by running
witness verify --verifier-kms-ref [KMS_REF] -a [ATTESTATION] -f [ARTIFACT] -p policy.signed.json
using an AWS IAM account without theVerify
permission. It will succeed sometimes and fail other times.Which issue(s) this PR fixes (optional)
Acceptance Criteria Met
Special notes for your reviewer: