Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent early return in verifier #484

Merged
merged 1 commit into from
Aug 12, 2024
Merged

prevent early return in verifier #484

merged 1 commit into from
Aug 12, 2024

Conversation

joshdabosh
Copy link
Contributor

What this PR does / why we need it

During verification there is nondeterministic behavior if the flag --verifier-kms-aws-remote-verify=[true/false] is not specified. I found that this is because there is an early return causing the default boolean true value to not be set for the verifyRemotely attribute.

In some instances, the first ksp in the outer loop will be kms-gcp. If using an AWS reference, then the proper verifyRemotely setter will not be run. Other times, the first ksp will be kms-aws and the proper setter will be called.

You can check this by running witness verify --verifier-kms-ref [KMS_REF] -a [ATTESTATION] -f [ARTIFACT] -p policy.signed.json using an AWS IAM account without the Verify permission. It will succeed sometimes and fail other times.

Which issue(s) this PR fixes (optional)

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit f653094
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/66b96cefed56560008750311
😎 Deploy Preview https://deploy-preview-484--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Joshua Wang <[email protected]>
@jkjell jkjell merged commit 29117fc into in-toto:main Aug 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants