Skip to content

change geschat_schadebedrag into SchadeBedragOmschrijving #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: uat
Choose a base branch
from
Open

change geschat_schadebedrag into SchadeBedragOmschrijving #586

wants to merge 1 commit into from

Conversation

SanderDevisscher
Copy link
Collaborator

@SanderDevisscher SanderDevisscher self-assigned this Jul 17, 2025
@SanderDevisscher SanderDevisscher added the backoffice issue met betrekking tot data kwaliteit label Jul 17, 2025
Copilot
Copilot AI reviewed Jul 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the geschat_schadebedrag field to SchadeBedragOmschrijving in the raw data creation step.

  • Updated the column list in createRawData to use the new field name.
  • Ensured downstream code will reference the updated column.
Comments suppressed due to low confidence (2)

reporting-grofwild/R/data_create.R:395

  • [nitpick] The new column name SchadeBedragOmschrijving uses CamelCase, which is inconsistent with the snake_case style of other columns (e.g., provincie, fbz). Consider renaming to schade_bedrag_omschrijving or updating other names for consistency.
        "SchadeBedragOmschrijving", "type_melding")]

reporting-grofwild/R/data_create.R:395

  • Update any documentation, function comments, or vignettes that reference the old geschat_schadebedrag field to reflect the new SchadeBedragOmschrijving name.
        "SchadeBedragOmschrijving", "type_melding")]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mvarewyck mvarewyck Awaiting requested review from mvarewyck

@SaarJunius SaarJunius Awaiting requested review from SaarJunius

@soriadelva soriadelva Awaiting requested review from soriadelva

At least 1 approving review is required to merge this pull request.

Assignees

@SanderDevisscher SanderDevisscher

Labels
backoffice issue met betrekking tot data kwaliteit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SanderDevisscher