Skip to content

Further STATO reuse: Design Matrix and Z statistic #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2015

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Apr 20, 2015

I propose the following actions

Current definitions:

  • nidm:DesignMatrix : A matrix of values defining the explanatory variables used in a regression model. Each column corresponds to one explanatory variable, each row corresponds to one observation
  • nidm:ZStatistic : undefined

@jbpoline , @cmaumet: Comments?

(See PURL links for STATO definitions)

@cmaumet
Copy link
Member

cmaumet commented Mar 24, 2015

(Following the merge of PR #262, re-use of stato:Z-statistic is now implemented.)

Regarding nidm:DesignMatrix, one thing we need to think about is whether we want to deal with spatially varying design matrices (under discussion at #207). If so, we might want to have a definition that refer to the stato:DesignMatrix (similarly to what was done for nidm:ModelParametersEstimation in #141, cf. this comment) but is not strictly equivalent to it. Do you see what I mean?

@nicholst
Copy link
Contributor Author

OK, I'm fine with keeping nidm:DesignMatrix if it gives us greater flexibility later to deal with spatially designs. However, that's a rare enough use case I won't be upset if we don't explicitly represent it now.

@cmaumet
Copy link
Member

cmaumet commented Mar 24, 2015

+1 to re-use directly stato:'design matrix' (and keep the spatially varying design matrix for a later extension).

@nicholst
Copy link
Contributor Author

Upon discussion with @cmaumet, we think we should not reuse the stato:'design matrix' term. The reasons is that our nidm:DesignMatrix entity can take some very fMRI-specific attributes, like HRF and drift descriptions.

We propose a definition that closely follows and references the STATO definition, however:

@khelm
Copy link
Contributor

khelm commented Apr 14, 2015

+1 , sounds good to me.

@cmaumet
Copy link
Member

cmaumet commented Apr 20, 2015

Thank you! Now implemented and ready for release.

@cmaumet cmaumet added the merge label Apr 20, 2015
cmaumet pushed a commit that referenced this pull request Apr 20, 2015
Further STATO reuse: Design Matrix and Z statistic
@cmaumet cmaumet merged commit 7f5e4c6 into incf-nidash:master Apr 20, 2015
@cmaumet cmaumet deleted the def_design_matrix branch April 20, 2015 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants