Skip to content

Migrate to pnpm #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Migrate to pnpm #2276

wants to merge 12 commits into from

Conversation

jrmajor
Copy link

@jrmajor jrmajor commented Mar 16, 2025

Replaces #1875.

@jrmajor jrmajor force-pushed the pnpm branch 5 times, most recently from 3703c73 to be24af3 Compare March 16, 2025 16:15
@pascalbaljet
Copy link
Contributor

Thanks for this, @jrmajor, looks great! I've updated it to reflect the latest changes and added some more scripts.

Just wondering if you thought there was anything left to do since you marked it as draft?

@jrmajor
Copy link
Author

jrmajor commented Jun 6, 2025

Thank you @pascalbaljet! IIRC, i just wanted to do some more testing to make sure that this doesn't break anything. Let me do a quick self-review to see if there are any todos left.

@jrmajor jrmajor marked this pull request as ready for review June 6, 2025 11:52
@jrmajor
Copy link
Author

jrmajor commented Jun 6, 2025

@pascalbaljet Ready for review. Are the test:*:serve scripts needed for something? Seems like that server is only used by Playwright, which doesn't use these scripts anyway.

@pascalbaljet
Copy link
Contributor

@pascalbaljet Ready for review. Are the test:*:serve scripts needed for something? Seems like that server is only used by Playwright, which doesn't use these scripts anyway.

Just a shortcut to spin up the test server so we can easily tinker with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants