Skip to content

Conversation

@BoumouzounaBrahimVall
Copy link

Includes optional interceptors and compat mode notes; no runtime code changes.

Open Source License Notice for Contributors

If you are contributing a recipe to this repository, you agree to license your contribution under the terms of the CC BY-SA 4.0 license.

If you have any questions, please reference the CONTRIBUTING.md or LICENSE.md file for more information.

Thank you for your contribution!

Includes optional interceptors and compat mode notes; no runtime code changes.
Copy link
Member

@cdanwards cdanwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid migration guide! Thanks for the contribution @BoumouzounaBrahimVall!

One small nit that you can address if you want.
Consider removing the emojis from the logging interceptor for consistency with Ignite's typically emoji-free code style (the 🚀, ✅, ❌ in setupLoggingInterceptor).

@BoumouzounaBrahimVall
Copy link
Author

Solid migration guide! Thanks for the contribution @BoumouzounaBrahimVall!

One small nit that you can address if you want. Consider removing the emojis from the logging interceptor for consistency with Ignite's typically emoji-free code style (the 🚀, ✅, ❌ in setupLoggingInterceptor).

Done. I’m used to adding them in my logs because it makes them more readable. I didn’t know Ignite typically follows an emoji-free code style, thanks for the heads-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants