Skip to content

Commit

Permalink
seperated dev and prod dependencies;
Browse files Browse the repository at this point in the history
simplified linting workflow
  • Loading branch information
infinityofspace committed Nov 14, 2024
1 parent e83d2fb commit 76a4475
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 33 deletions.
34 changes: 3 additions & 31 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,38 +25,10 @@ jobs:
pip install flake8 pylint
- name: Install project requirements
run: pip install -r requirements.txt
run: pip install -r requirements-dev.txt

- name: Lint with flake8
run: flake8 certbot_dns_porkbun --count --select=E9,F63,F7,F82 --show-source --statistics
run: flake8 certbot_dns_porkbun --count --ignore E501 --show-source --statistics

- name: Lint with pylint
run: pylint certbot_dns_porkbun -d C,R,W

linting-setup-install:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]

steps:
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: install linting requirements
run: |
pip install --upgrade pip
pip install flake8 pylint
- name: Install project
run: pip install .

- name: Lint with flake8
run: flake8 certbot_dns_porkbun --count --select=E9,F63,F7,F82 --show-source --statistics

- name: Lint with pylint
run: pylint certbot_dns_porkbun -d C,R,W
run: pylint certbot_dns_porkbun --disable C0301
5 changes: 5 additions & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-r requirements.txt
responses~=0.25
ruff~=0.7
flake8~=7.1
pylint~=3.3
2 changes: 0 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@ certbot>=1.18.0,<4.0
pkb_client>=2.0,<3.0
dnspython>=2.0.0,<3.0
tldextract>=5.1.2,<6.0
ruff~=0.7
responses~=0.25

0 comments on commit 76a4475

Please sign in to comment.