Skip to content

Feature/speed #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 3, 2025
Merged

Feature/speed #457

merged 28 commits into from
Jun 3, 2025

Conversation

iruzevic
Copy link
Member

@iruzevic iruzevic commented Jun 2, 2025

What’s Changed:

  • Refactored all internal helpers to cache everything possible
  • All repeatable internal operations are now cached and loaded from memory
  • Adding tests

Benchmark:

  • about - 0.41 -> 0.25s
  • blog - 0.54 -> 0.29s
  • careers - 0.51 -> 0.21s
  • contact - 1.22 -> 0.7s
  • home - 0.37 -> 0.25s
  • work - 0.5 -> 0.27s

about-a
about-b
blog-a
blog-b
careers-a
careers-b
contact-a
contact-b
home-a
home-b
work-a
work-b

Screenshot 2025-06-02 at 12 13 05
Screenshot 2025-06-02 at 12 13 11

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 54.95251% with 332 lines in your changes missing coverage. Please review.

Project coverage is 15.18%. Comparing base (ad226ce) to head (b6374de).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
src/Helpers/AttributesTrait.php 0.00% 103 Missing ⚠️
src/Helpers/StoreBlocksTrait.php 0.00% 100 Missing ⚠️
src/Helpers/PostTrait.php 0.00% 57 Missing ⚠️
src/Helpers/RenderTrait.php 14.51% 53 Missing ⚠️
src/Helpers/CacheTrait.php 94.11% 8 Missing ⚠️
src/Helpers/GeneralTrait.php 94.11% 8 Missing ⚠️
src/Helpers/PathsTrait.php 94.91% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ad226ce) and HEAD (b6374de). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ad226ce) HEAD (b6374de)
unittests 2 1
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #457       +/-   ##
=============================================
- Coverage     81.49%   15.18%   -66.31%     
+ Complexity     1351     1201      -150     
=============================================
  Files           138       82       -56     
  Lines          6348     4519     -1829     
=============================================
- Hits           5173      686     -4487     
- Misses         1175     3833     +2658     
Flag Coverage Δ
unittests 15.18% <54.95%> (-66.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

piqusy
piqusy previously approved these changes Jun 2, 2025
Copy link
Contributor

@piqusy piqusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏🏼

dadadavorin
dadadavorin previously approved these changes Jun 2, 2025
@iruzevic iruzevic dismissed stale reviews from dadadavorin and piqusy via ce0f489 June 3, 2025 06:53
@iruzevic iruzevic merged commit 70165f7 into main Jun 3, 2025
3 of 5 checks passed
@iruzevic iruzevic deleted the feature/speed branch June 3, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants