Add support for parameter binding to built queries #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so that they can be used with built queries, and added support for that. Decoupled requiresPost from parameters, as they are unrelated. Made InfluxDBService more consistent, by making all query methods use GET, and all postQuery methods use POST.
|
@majst01, are these failures real? I can't figure out what they mean. |
There has been no CI build for a long time, so i dont know |
|
Ok, figured it out - I introduced an overloading bug while reworking |
|
Nice, can you add the relevant changes to the documentation ? |
Improve test
Done. Also, improved the test a bit. |
|
I tend to merge this PR as the very last one before archiving this repo, WDYT ? |
|
From my perspective, there's still no viable alternative to InfluxQL v1 (Flux is effectively deprecated, and OSS v3 is in beta), so this library is very much in prime time. Am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled up bound parameter support from
BoundParameterQuerytoQuery, so that they can be used with built queries, and added support for that.Also:
requiresPostfrom parameters, as they are unrelatedInfluxDBServicemore consistent, by making allquerymethods useGET, and allpostQuerymethods usePOSTFixes #1009.