Skip to content

Add missing cli and config option #24697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamilernerd wants to merge 3 commits into
base: main-2.x
Choose a base branch
from
Open

Add missing cli and config option #24697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a44ed92
Add back missing compaction throughput options
kamilernerd Feb 20, 2024
e5843b9
Improve description
kamilernerd Feb 20, 2024
8d1fcdd
Merge branch 'influxdata:main-2.x' into main-2.x
kamilernerd Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/influxd/launcher/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,11 @@ func (o *InfluxdOpts) BindCliOpts() []cli.Opt {
Flag: "storage-compact-full-write-cold-duration",
Desc: "The duration at which the engine will compact all TSM files in a shard if it hasn't received a write or delete.",
},
{
DestP: &o.StorageConfig.Data.CompactThroughput,
Flag: "storage-compact-throughput",
Desc: "The rate limit in bytes per second that we will allow TSM compactions to write to disk. This option overwrites throughput-burst when throughput > throughput-burst",
},
{
DestP: &o.StorageConfig.Data.CompactThroughputBurst,
Flag: "storage-compact-throughput-burst",
Expand Down
1 change: 1 addition & 0 deletions cmd/influxd/upgrade/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var passthroughConfigRules = map[string]string{
"data.cache-snapshot-memory-size": "storage-cache-snapshot-memory-size",
"data.cache-snapshot-write-cold-duration": "storage-cache-snapshot-write-cold-duration",
"data.compact-full-write-cold-duration": "storage-compact-full-write-cold-duration",
"data.compact-throughput": "storage-compact-throughput",
"data.compact-throughput-burst": "storage-compact-throughput-burst",
"data.max-concurrent-compactions": "storage-max-concurrent-compactions",
"data.max-index-log-file-size": "storage-max-index-log-file-size",
Expand Down