Make the alerta auth token prefix configurable and default it to Bearer. #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allen13
force-pushed
the
master
branch
4 times, most recently
from
74cb7dc
to
ceb2651
Compare
nathanielc
suggested changes
Feb 7, 2017
There was a problem hiding this comment.
@allen13 Thanks for tracking this down and providing a flexible solution.
I have one suggested change below.
services/alerta/config.go
Outdated
| @@ -15,6 +15,8 @@ type Config struct { | |||
| InsecureSkipVerify bool `toml:"insecure-skip-verify" override:"insecure-skip-verify"` | |||
| // The authentication token for this notification, can be overridden per alert. | |||
| Token string `toml:"token" override:"token,redact"` | |||
| // The prefix for the Authentication field where the token is stored | |||
| TokenPrefix string `toml:"token-prefix" override:"token-prefix"` | |||
There was a problem hiding this comment.
Can you add a comment here that if you are on an older version of Alerta you may want to set this to Key? Along those lines can you update the example config in etc/kapacitor/kapacitor.conf with this new option and comments as well.
nathanielc
added a commit
that referenced
this pull request
Feb 7, 2017
Make the alerta auth token prefix configurable and default it to Bearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
Addresses this issue: #1165