Change default token-prefix to proper one for the Alerta service. This closes #1165 #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM (though I haven't actually tested it) |
|
@nathanielc (you're first in #1165) sorry for disturbing you, can you take a look and it's okay and then merge it? |
SebastianCzoch
force-pushed
the
feature/alerta_token_service
branch
2 times, most recently
from
52ae224
to
f075b83
Compare
SebastianCzoch
force-pushed
the
feature/alerta_token_service
branch
from
f075b83
to
7f485b5
Compare
|
I've update this PR with latest master branch |
|
Any reason why this hasn't been merged? It catches a lot of people out and is creating extra support work on the Alerta side to constantly address user confusion around this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Alerta documentation says,
Keyis properAuthorizationheader token-prefix.Link to issue: #1165