test(testutil): Performance and code quality improvements on container #17276
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Thanks for the PR @skartikey! I'm not sure where the performance improvement is but as I said in another, this is test-only code and therefore performance doesn't matter too much. Please find some comments in the code...
testutil/container.go
Outdated
| @@ -193,6 +202,29 @@ func (c *Container) GetInfo() (string, error) { | |||
| return "", fmt.Errorf("getting provider failed: %w", err) | |||
| } | |||
|
|
|||
| // Try direct inspection first - much more efficient than listing all images | |||
| imageInfo, _, err := provider.Client().ImageInspectWithRaw(c.ctx, ci.ContainerJSONBase.Image) | |||
There was a problem hiding this comment.
This function is deprecated according to the linter.
There was a problem hiding this comment.
updated with the new method ImageInspect
skartikey
force-pushed
the
testutil_container_optimizations
branch
from
4cad8ac to
2ee0cf7
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes Docker container operations in the testutil package to improve performance, particularly in environments with many Docker images or when processing multiple containers.
ImageList()- retrieves ALL Docker images, then searches linearlyImageInspect()- directly inspects the specific image by IDChecklist
Related issues
resolves #