Skip to content

chore: Replace honeybadger-js with honeybadger-io/js #6904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

abshierjoel
Copy link
Contributor

Part of #1980

This is based on honeybadger's migration guide here: https://docs.honeybadger.io/lib/javascript/support/upgrading-to-v3/

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@abshierjoel abshierjoel requested a review from wdoconnell June 26, 2024 21:31
@abshierjoel abshierjoel requested a review from a team as a code owner June 26, 2024 21:31
@hansenreid
Copy link
Contributor

@wdoconnell can you take a look at this?

@wdoconnell
Copy link
Contributor

Taking a look now 👍

@wdoconnell
Copy link
Contributor

This generally looks correct but I need to spend a little more time with it - the case that applies to us is somewhat different from the guide in that we're going from 1.x of the client-side package (instructions are for 2.x of client side package or 1.x of node package).

@wdoconnell
Copy link
Contributor

wdoconnell commented Jul 29, 2024

Finished reviewing - this looks correct. The guide isn't specific to honeybadger-v1.x upgrades but for our purposes the changes required look to be the same.

Only other thing I'd note from the upgrade instructions:
Previously deprecated snake case config options such as api_key, project_root, etc. are no longer supported. Use apiKey, projectRoot instead.

Importantly, this only affects the config options themselves. The arguments passed to the honeybadger v1 api (see scripts/upload_sourcemap.sh) are unchanged, so "api_key" is there still "api_key" rather than apiKey.

I'll monitor this after it merges to make sure we don't lose honeybadger reporting.

@wdoconnell wdoconnell added this pull request to the merge queue Jul 29, 2024
Merged via the queue into master with commit c8de045 Jul 29, 2024
6 checks passed
@wdoconnell wdoconnell deleted the chore/replace-honeybadger-js-with-io branch July 29, 2024 21:39
wdoconnell added a commit that referenced this pull request Jul 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants