[ADD] l10n_ar_edi_ux, l10n_ar_currency_update: Re use AFIP connection #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the company selection logic for AFIP currency updates by not only checking for valid certificates but also verifying that companies have valid connections to the required web services.
- Extracts certificate validation logic into a reusable method
_find_company_with_valid_certificate - Adds web service connection validation to ensure companies can actually connect to AFIP services
- Simplifies the main currency parsing logic by using the new helper method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zaoral
force-pushed
the
18.0-h-98418-kz
branch
2 times, most recently
from
f78f7e6 to
6adac78
Compare
zaoral
commented
Sep 11, 2025
zaoral
commented
Sep 11, 2025
zaoral
force-pushed
the
18.0-h-98418-kz
branch
2 times, most recently
from
64ea5a7 to
cce04d7
Compare
zaoral
changed the title
zaoral
force-pushed
the
18.0-h-98418-kz
branch
from
91faaad to
e1a9dd3
Compare
Improves the company selection logic for AFIP currency updates by not only checking for valid certificates but also verifying that companies have valid connections to the required web services. * Extracts certificate validation logic into a reusable method _find_company_with_valid_certificate * Adds web service connection validation to ensure companies can actually connect to AFIP services * FIX: Only ask this once outsite for loop
Update From Padron AFIP is only working when * my login company has a valid certificate and connection to ws_sr_constancia_inscripcion webservice * my login company has not certificate and there is only one other company with certificate and connection to the ws_sr_constancia_inscripcion webservice. This PR changes the logic to always try to find a company that actually can connect to the webserive and use that one in order to connect to AFIP to get padron data.
zaoral
force-pushed
the
18.0-h-98418-kz
branch
from
e1a9dd3 to
29ee0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update From Padron AFIP and "Currency rate sincronization are only working if:
wsbe/ws_sr_constancia_inscripcion webservices.
This PR changes the logic to always try to find a company that actually can connect to the webserive and use that one in order
to connect to AFIP, avoiding trying to connect with an invalid connection which results on not working padron an rate syncronization (mostly silence errors)