Skip to content

[ADD]partner_creation_access: new module in 18.0 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mav-adhoc
Copy link
Contributor

No description provided.

@roboadhoc
Copy link

@mav-adhoc mav-adhoc force-pushed the 18.0-t-50905-mav branch 3 times, most recently from 5cabe5c to 2baf85c Compare May 15, 2025 17:21
@mav-adhoc mav-adhoc requested a review from Copilot May 15, 2025 19:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Odoo 18.0 module that restricts partner/contact creation to users in the “Contact Creation” group.

  • Enforce partner creation only for users in the base.group_partner_manager group
  • Scaffold module with manifest and package initialization
  • Provide README with installation, configuration, and usage instructions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
partner_creation_access/models/res_partner.py Override create to enforce partner creation access
partner_creation_access/models/init.py Import res_partner model
partner_creation_access/init.py Import models package
partner_creation_access/manifest.py Module metadata and dependencies
partner_creation_access/README.rst Module documentation
Comments suppressed due to low confidence (2)

partner_creation_access/models/res_partner.py:9

  • [nitpick] Rename the parameter vals to vals_list to match the @api.model_create_multi convention and clarify that it's a list of value dictionaries.
    def create(self, vals):

partner_creation_access/models/res_partner.py:8

  • There are no tests for the new access restriction logic; consider adding unit or integration tests to verify that unauthorized users are blocked and authorized users can create partners.
    @api.model_create_multi

@ced-adhoc
Copy link
Contributor

@roboadhoc r+

@roboadhoc roboadhoc closed this in b1bbec4 May 21, 2025
@roboadhoc roboadhoc added the 17.1 label May 21, 2025
@fw-bot-adhoc fw-bot-adhoc deleted the 18.0-t-50905-mav branch June 4, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants