[ADD]partner_creation_access: new module in 18.0#128
Closed
mav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[ADD]partner_creation_access: new module in 18.0#128mav-adhoc wants to merge 1 commit intoingadhoc:18.0from
mav-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
5cabe5c to
2baf85c
Compare
2baf85c to
081953e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Odoo 18.0 module that restricts partner/contact creation to users in the “Contact Creation” group.
- Enforce partner creation only for users in the
base.group_partner_managergroup - Scaffold module with manifest and package initialization
- Provide README with installation, configuration, and usage instructions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| partner_creation_access/models/res_partner.py | Override create to enforce partner creation access |
| partner_creation_access/models/init.py | Import res_partner model |
| partner_creation_access/init.py | Import models package |
| partner_creation_access/manifest.py | Module metadata and dependencies |
| partner_creation_access/README.rst | Module documentation |
Comments suppressed due to low confidence (2)
partner_creation_access/models/res_partner.py:9
- [nitpick] Rename the parameter
valstovals_listto match the @api.model_create_multi convention and clarify that it's a list of value dictionaries.
def create(self, vals):
partner_creation_access/models/res_partner.py:8
- There are no tests for the new access restriction logic; consider adding unit or integration tests to verify that unauthorized users are blocked and authorized users can create partners.
@api.model_create_multi
Contributor
|
@roboadhoc r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.