test: Add upstream html5lib-tests #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use them for the tokenizer, benchmarks & to generate feedback tests.
fb55
commented
Mar 11, 2022
| @@ -8,10 +7,3 @@ const tokenizerOpts = { | |||
| }; | |||
|
|
|||
| generateTokenizationTests('Tokenizer', dataPath.pathname, (handler) => new Tokenizer(tokenizerOpts, handler)); | |||
|
|
|||
| describe('tokenizer', () => { | |||
There was a problem hiding this comment.
This test was upstreamed in html5lib/html5lib-tests#145
43081j
reviewed
Mar 11, 2022
| @@ -118,7 +118,8 @@ function createParsingTest<T extends TreeAdapterTypeMap>( | |||
| }; | |||
| } | |||
|
|
|||
| const treePath = new URL('../data/html5lib-tests/tree-construction', import.meta.url); | |||
| // TODO: Stop using the fork here. | |||
There was a problem hiding this comment.
do we have an issue somewhere for this? would be good to mention the number i think
43081j
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use them for the tokenizer, benchmarks & to generate feedback tests.
html5lib/html5lib-tests#144 got merged, which allows us to adopt the upstream tests.