refactor: add rollback support to epoch activity counter #142
Conversation
…ory. - Refactored state management to include for tracking epoch activities. - Introduced for publishing epoch activity messages. - Added to manage historical epoch data. - Updated REST handlers to support new state management structure. - Improved handling of block information and epoch transitions.
…vity_couter module - Introduced query to retrieve total blocks minted for specified VRF key hashes. - Updated to include response type. - Enhanced state management to support retrieval of total blocks minted by pools. - Refactored REST handlers to utilize the new total blocks minted query, improving data aggregation for pool statistics.
golddydev
requested review from
whankinsiv and
sandtreader
and removed request for
whankinsiv
There was a problem hiding this comment.
If the BlockfrostREST now covers this through the query, this might be a good time to kill this.
There was a problem hiding this comment.
Okay, I"ll remove rest.rs and move to blockfrost module.
There was a problem hiding this comment.
827462f
This is fixed
|
|
||
| // History of epochs (disabled by default) | ||
| epoch_history: Option<BTreeMap<u64, EpochActivityMessage>>, | ||
| // Total blocks minted till epoch N |
There was a problem hiding this comment.
Comment: ... for each SPO
Also is it the start of epoch N or the end?
There was a problem hiding this comment.
- or actually, reading the code, the current state in this case?
There was a problem hiding this comment.
Oh, that is actually till current block number.
So total_blocks_minted is updated for every block.
There was a problem hiding this comment.
Let me update the comments.
There was a problem hiding this comment.
Updated comment
| @@ -173,12 +172,8 @@ impl SPOState { | |||
| { | |||
| let span = | |||
| info_span!("spo_state.handle_epoch_activity", block = block_info.number); | |||
| async { | |||
| span.in_scope(|| { | |||
There was a problem hiding this comment.
Interesting - if this is a direct replacement, this needs sharing!
…ounter module - Implemented new REST handlers for fetching the latest epoch and specific epoch information. - Removed obsolete REST handling code to streamline the module.
📋 Overview
This PR introduces improvements to the Epoch Activity Counter module, focusing on enhanced state management, rollback support, historical data storage capabilities.
🔧 Key Changes
1. Enhanced State Management with Rollback Support
StateHistory<State>to handle blockchain rollbacks gracefully2. Historical Data Storage System
store-historyconfiguration option to enable/disable historical data storageDashMapfor thread-safe concurrent access to historical data3. Improved Query System
GetTotalBlocksMintedByPoolsquery to retrieve cumulative block minting datapools.rstoepochs.rsfor better organization4. Architecture Improvements
epoch_activity_publisher.rs: Dedicated message publishingepochs_history.rs: Historical data managementstore_config.rs: Configuration handling5. Dependency Updates
tracing-subscriberdependabot alert.dashmapfor concurrent hash map operations🧪 Testing