Skip to content

fix(cat-voices): decode account public id username #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

damian-molinski
Copy link
Contributor

Description

Decodes correctly account public profile username

Related Issue(s)

Fixes #2738

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski self-assigned this Jun 9, 2025
@damian-molinski damian-molinski added the bug Something isn't working label Jun 9, 2025
@damian-molinski damian-molinski added review me PR is ready for review dart Pull requests that update Dart code labels Jun 9, 2025
@damian-molinski damian-molinski moved this from New to 👀 In review in Catalyst Jun 9, 2025
@damian-molinski damian-molinski marked this pull request as ready for review June 9, 2025 11:23
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Test Report | ${\color{lightgreen}Pass: 788/792}$ | ${\color{red}Fail: 0/792}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LynxLynxx LynxLynxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski enabled auto-merge (squash) June 10, 2025 07:27
@damian-molinski damian-molinski merged commit 344abc8 into main Jun 10, 2025
37 of 38 checks passed
@damian-molinski damian-molinski deleted the fix/decode_public_id_diacritical_username_2738 branch June 10, 2025 07:56
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dart Pull requests that update Dart code review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: [Account] User cannot edit display name with diacritical symbols correctly
3 participants