fix(cat-voices): sharing proposals url #2749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damian-molinski
added
bug
|
✅ Test Report | |
dtscalac
reviewed
Jun 10, 2025
| @@ -177,7 +180,7 @@ class _ReviewerCard extends StatelessWidget { | |||
| ), | |||
| _StayInvolvedActionButton( | |||
| title: context.l10n.becomeReviewer, | |||
| urlString: VoicesConstants.becomeReviewerUrl(), | |||
| urlString: Uri.decodeFull(ShareManager.of(context).becomeReviewer().toString()), | |||
There was a problem hiding this comment.
Do we need to call Uri.decodeFull here? Why can't the ShareManager give us directly what we need to share? If we need to remember to call Uri.decodeFull whenever we share then at some point we might forget about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes sharing proposal url. Problem was that "?" used for query
versionparameter was encoded which resulted later in router thinking11111%3Fversion=123412412is an id.Related Issue(s)
Fixes #2743
Description of Changes