Skip to content

Release fs-sim-0.4.0.0 and fs-api-0.4.0.0 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Release fs-sim-0.4.0.0 and fs-api-0.4.0.0 #102

merged 1 commit into from
Jun 3, 2025

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented May 30, 2025

No description provided.

@geo2a geo2a requested a review from a team as a code owner May 30, 2025 11:58
@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from 3a01630 to e7b0c03 Compare May 30, 2025 12:00
jasagredo
jasagredo requested changes May 30, 2025
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you need to also change the README badges

@jasagredo
Copy link
Contributor

I also like adding a source-repository this to Hackage packages for informational purposes

@geo2a
Copy link
Contributor Author

geo2a commented May 30, 2025

Actually you need to also change the README badges
I don't think I do, looks like they some how automatically pick up the newest version:

[![Hackage Version](https://img.shields.io/hackage/v/fs-sim?label=hackage%20fs-sim)](https://hackage.haskell.org/package/fs-sim)

I took inspiration from the last release PR and the badges are unchanged there.

@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from e7b0c03 to c3d58f0 Compare May 30, 2025 12:25
@jorisdral
Copy link
Contributor

jorisdral commented Jun 2, 2025 •
edited
Loading

Just leaving a link here to a comment I left on a PR that was already merged: #101 (review)

(and true, the badges update themselves automatically)

jasagredo
jasagredo requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR based on input-output-hk/io-sim#216. Changes here look fine, but we need to resolve that issue before releasing.

@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from 967af4a to c3d58f0 Compare June 3, 2025 11:28
@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from c3d58f0 to e393b4b Compare June 3, 2025 11:44
jorisdral
jorisdral reviewed Jun 3, 2025
View reviewed changes
fs-api/CHANGELOG.md Outdated
@@ -16,14 +18,14 @@

* Make it build with `ghc-9.12`.
* Drop support for `ghc-8.10` and `ghc-9.2`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still says that support for ghc-9.2 is dropped

fs-sim/CHANGELOG.md Outdated
@@ -32,8 +34,8 @@
### Patch

* Make it build with `ghc-9.12`.
* Support `io-classes-1.8`.
* Drop support for `ghc-8.10` and `ghc-9.2`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still says that support for ghc-9.2 is dropped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from e393b4b to 2857f9b Compare June 3, 2025 11:46
@geo2a geo2a enabled auto-merge June 3, 2025 11:46
@geo2a geo2a added this pull request to the merge queue Jun 3, 2025
Merged via the queue into input-output-hk:main with commit 77e4809 Jun 3, 2025
22 checks passed
@geo2a geo2a deleted the geo2a/io-classes-1.8 branch June 3, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisdral jorisdral jorisdral left review comments

@jasagredo jasagredo jasagredo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geo2a @jasagredo @jorisdral