Skip to content

Feat/lw 12399 sign multisig tx with hw #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Mar 7, 2025

Checklist

  • JIRA - \LW-12399
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • refactor getParentWalletCIP1854Account to also return parent wallet
  • detect proper type of "parent wallet" for shared wallet while signing/submitting tx

Testing

  • entire sign/submit flow should be tested

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Mar 7, 2025
@vetalcore vetalcore requested a review from a team as a code owner March 7, 2025 14:54
Copy link

sonarqubecloud bot commented Mar 7, 2025

@vetalcore vetalcore force-pushed the feat/lw-12398-enable-add-shared-wallet-for-hw branch from 57530df to e596784 Compare March 7, 2025 20:25
Base automatically changed from feat/lw-12398-enable-add-shared-wallet-for-hw to main March 14, 2025 12:26
@vetalcore vetalcore force-pushed the feat/lw-12399-sign-multisig-tx-with-hw branch 2 times, most recently from 8d36ceb to f1034d9 Compare May 27, 2025 08:32
@lace-bot
Copy link
Collaborator

lace-bot commented May 27, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for f4342f3a

passed failed skipped flaky total result
Total 33 0 4 0 37

@AngelCastilloB AngelCastilloB force-pushed the feat/lw-12399-sign-multisig-tx-with-hw branch 5 times, most recently from 6f0d7d9 to edad259 Compare June 6, 2025 07:27
@vetalcore vetalcore force-pushed the feat/lw-12399-sign-multisig-tx-with-hw branch 3 times, most recently from 23206cd to 2a8d28e Compare June 6, 2025 10:13
@vetalcore vetalcore force-pushed the feat/lw-12399-sign-multisig-tx-with-hw branch from 2a8d28e to f4342f3 Compare June 6, 2025 10:16
Copy link

sonarqubecloud bot commented Jun 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants