Skip to content

hyp3: tropo_pyaps support via incidence angle #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2021
Merged

hyp3: tropo_pyaps support via incidence angle #567

merged 6 commits into from
Jun 3, 2021

Conversation

cirrusasf
Copy link
Contributor

@cirrusasf cirrusasf commented Jun 2, 2021 •
edited by yunjunz
Loading

Description of proposed changes

  • support loading incidence angle file in prep_hyp3.py
  • convert UTM coordinates to lat/lon for tropospheric correction with PyAPS via tropo_pyaps3.py (ASF HyP3 Support #540)
  • bugfix in tsview.py for the x coordinate checking if file is not in lat/lon coordinates.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@cirrusasf cirrusasf mentioned this pull request Jun 2, 2021
Closed
6 tasks
@yunjunz yunjunz self-requested a review June 2, 2021 19:26
@yunjunz
move gdal import inside func
b90b40d 
and codacy suggestions
@yunjunz yunjunz changed the title modify some coed in mintpy to allow it works with ASF hyp3 product hyp3: tropo_pyaps support via incidence angle Jun 2, 2021
cirrusasf
cirrusasf commented Jun 2, 2021
View reviewed changes
Copy link
Contributor Author

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the modification of the code is good.

cirrusasf
cirrusasf commented Jun 2, 2021
View reviewed changes
Copy link
Contributor Author

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

yunjunz
yunjunz approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cirrusasf!

@yunjunz yunjunz merged commit 4ee12c6 into insarlab:main Jun 3, 2021
@welcome
Copy link

welcome bot commented Jun 3, 2021

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

@yunjunz yunjunz linked an issue Jun 3, 2021 that may be closed by this pull request
mintPy has issue to work with hyp3 product #562
Closed
@cirrusasf cirrusasf deleted the asf-Mintpy branch June 3, 2021 19:54
@yunjunz yunjunz added this to the UTM coordinate support milestone Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UTM coordinate support
Development

Successfully merging this pull request may close these issues.

mintPy has issue to work with hyp3 product
2 participants
@cirrusasf @yunjunz