Skip to content

save_gdal.py: support UTM projection #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

pbrotoisworo
Copy link
Contributor

@pbrotoisworo pbrotoisworo commented Aug 23, 2021

Description of proposed changes

  • Add EPSG to file attributes in readfile.py
  • array2raster now accepts additional argument for EPSG code in save_gdal.py (default is 4326). This loads the EPSG from file attributes.
  • Fix typo in array2raster function

Reminders

  • Fix save_gdal.py does not work with hyp3 data #644
  • Pass Codacy code review (green)
  • Pass Circle CI / local test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

- Add EPSG to file attributes in readfile.py
- array2raster now accepts additional argument for EPSG code in save_gdal.py
@yunjunz yunjunz self-requested a review August 23, 2021 17:46
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pbrotoisworo!

@yunjunz yunjunz changed the title save_gdal.py: Fix bug when handling UTM projections save_gdal.py: support UTM projection Aug 23, 2021
@yunjunz yunjunz added this to the UTM coordinate support milestone Aug 23, 2021
@yunjunz
Copy link
Member

yunjunz commented Aug 23, 2021

Installation failed on Circle CI but testings on my local machine passed without issues. The circle CI issue is not related to the code change in this PR (scikit-image/scikit-image#5528), so it's fine to merge.

@yunjunz yunjunz merged commit 0c5d79d into insarlab:main Aug 23, 2021
@pbrotoisworo pbrotoisworo deleted the save_gdal branch August 23, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_gdal.py does not work with hyp3 data
2 participants