-
-
Notifications
You must be signed in to change notification settings - Fork 9
{teal}
module returns a teal_report
object that extends from teal_data
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
averissimo
wants to merge
9
commits into
main
Choose a base branch
from
teal_reportable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2025
{teal}
module returns a teal_report
object that extends from teal_data
insightsengineering/teal#1541
Open
I've suggested "code verified/unverified" because: 1. It's concise and clear 2. It focuses on what's actually being verified (the code that created the data) 3. It removes the redundant "teal_data object" since this is already known from the context
Code Coverage Summary
Diff against main
Results for commit: 8585f6c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 15 suites 1s ⏱️ Results for commit 8585f6c. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes:
Built on top of:
teal.reporter
Cards teal.reporter#307purl=FALSE
to the chunk producing error #307 will be closed once this PR is stable)Companion PRs:
{teal}
module returns ateal_report
object that extends fromteal_data
teal#1541{teal}
module returns ateal_report
object that extends fromteal_data
teal.code#255{teal}
module returns ateal_report
object that extends fromteal_data
#370{teal}
module returns ateal_report
object that extends fromteal_data
teal.reporter#331{teal}
module returns ateal_report
object that extends fromteal_data
teal.modules.general#884Changes description
teal_data
class to allow forteal_report
extensionshow()
method to remove reference toteal_data
specifically