Skip to content

Fixes failing "Add to Report" for modules that have DT table visualization #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fixes failing "Add to Report" for modules that have DT table visualization #900

wants to merge 10 commits into from

Conversation

averissimo
Copy link
Contributor

Pull Request

Changes description

  • Use of rtables::df_to_tt to produce report tables (that are decoratable)
  • Update decorators documentation to reflect
  • Minor code improvements that are marginally related (better variable name to separate data (raw data frame) from table (rtable or DT))

@averissimo averissimo changed the title Fixes when module trie Fixes failing "Add to Report" for modules that have DT table visualization Jul 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

Unit Tests Summary

  1 files  22 suites   1s ⏱️
144 tests 29 ✅ 115 💤 0 ❌
182 runs  67 ✅ 115 💤 0 ❌

Results for commit 2802f08.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------------------------------------
R/tm_a_pca.R                    890     890  0.00%    139-1162
R/tm_a_regression.R             774     774  0.00%    178-1057
R/tm_data_table.R               201     201  0.00%    100-349
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               144     133  7.64%    77-247
R/tm_g_association.R            345     345  0.00%    159-579
R/tm_g_bivariate.R              699     435  37.77%   331-827, 868, 979, 996, 1014, 1025-1047
R/tm_g_distribution.R          1126    1126  0.00%    158-1432
R/tm_g_response.R               370     370  0.00%    177-626
R/tm_g_scatterplot.R            735     735  0.00%    260-1099
R/tm_g_scatterplotmatrix.R      298     279  6.38%    198-533, 594, 608
R/tm_missing_data.R            1119    1119  0.00%    125-1421
R/tm_outliers.R                1057    1057  0.00%    164-1376
R/tm_t_crosstable.R             286     286  0.00%    175-519
R/tm_variable_browser.R         804     799  0.62%    89-1045, 1083-1266
R/utils.R                       151     135  10.60%   87-272, 302-338, 350-359, 364, 378-397
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9174    8859  3.43%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/tm_g_distribution.R       -2      -2  +100.00%
R/tm_missing_data.R         -1      -1  +100.00%
R/tm_outliers.R             -5      -5  +100.00%
TOTAL                       -8      -8  +0.00%

Results for commit: 2802f08

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

averissimo
averissimo commented Jul 25, 2025
View reviewed changes
R/tm_g_bivariate.R
@@ -561,7 +561,7 @@ srv_g_bivariate <- function(id,
datasets = data
)
qenv <- reactive(
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("teal.modules.general")') # nolint quotes
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr")') # nolint quotes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor fix that doesn't warrant a unique PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't add report that have DataTable tables [Bug]: Can't add a card to report from tm_g_distribution
1 participant
@averissimo