Skip to content

Use teal card internally in teal_reportable feature branch #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: teal_reportable
Choose a base branch
from
Open

Use teal card internally in teal_reportable feature branch #353

wants to merge 5 commits into from

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 9, 2025 •
edited
Loading

Changes description

  • teal_card is now used exclusively on internals of Reporter
    • Allows for edit cards using "ReportCard" in modules
    • Fix problem when doing c(teal_card("something"), list(1, 2)) as it was only saving the first element of list
    • Change examples to only use teal_card
  • Update documentation on ReportCard
    • Remove deprecation as we're not officially deprecating on this release
    • Reflect major usage of teal_card in Reporter

@averissimo averissimo added the core label Jul 9, 2025
averissimo added 2 commits July 9, 2025 20:13
@averissimo
Merge branch 'teal_reportable' into use_teal_card_internally@teal_rep…
f0deb32 
…ortable
@averissimo
Merge branch 'teal_reportable' into use_teal_card_internally@teal_rep…
9ac008b 
…ortable

* teal_reportable:
  fix: remove left padding in code element when inside pre
@gogonzo gogonzo self-assigned this Jul 14, 2025
gogonzo
gogonzo reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples in the Reporter are still dominated by ReportCard. Would be nice to replace them with teal_card so that nobody learns about class which is about to be deprecated

@averissimo
Copy link
Contributor Author

Good point, I tried to change them to be 50/50, but it makes more sense to be fully teal_card

@averissimo averissimo requested a review from gogonzo July 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo Awaiting requested review from gogonzo

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averissimo @gogonzo