Skip to content

Redesign and change position of reporter options #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Jul 17, 2025

Companion with insightsengineering/teal#1562

In this PR:

  • encoding related to download in reporter_previewer_ui has been removed and keep only buttons
  • introduced a preview_report_button_ui/srv as an equivalent of (download/reset)_report_button_ui/srv

todo:

  • buttons to move or remove reporter card in the previewer doesn't work
  • decide the fate of reporter_previewer_ui taking into account the future refactor of the teal.reporter
  • styling of the buttons in reporter_previewe_ui
  • fix tests

@gogonzo gogonzo changed the title Redesign UI ux@main Redesign and change position of reporter options Jul 17, 2025
Copy link
Contributor

github-actions bot commented Jul 17, 2025

Unit Tests Summary

  1 files   19 suites   27s ⏱️
197 tests 193 ✅ 0 💤 3 ❌ 1 🔥
335 runs  331 ✅ 0 💤 3 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit 34acddb.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo added the core label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants