Free transfers fix #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where library user needs to have libusb include folder in path. With this change only the PS3EYEDriver need to know about libusb.
…ure library user doesn't get a conflicting define for 'debug', which is pretty generic.
…in other projects.
…river for the PS3 eye camera, preventing us from using the device otherwise.
…during shutdown. It's illegal to free a transfer from within the transfer callback. Doing so can result in undefined behavior. From the docs of libusb_free_transfer, "It is not legal to free an active transfer (one which has been submitted and has not yet completed)." I've moved to free calls until after all transfers have finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I encountered some undefined behavior (and crash) due to the way transfers were freed during the transfer callback. I changed things a bit so now the transfers are freed after the wait for the number of active transfers to reach zero.
Cheers,
Marcel