RGBA format and fixed RGB debayer with vertical flip #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where library user needs to have libusb include folder in path. With this change only the PS3EYEDriver need to know about libusb.
…ure library user doesn't get a conflicting define for 'debug', which is pretty generic.
…in other projects.
…river for the PS3 eye camera, preventing us from using the device otherwise.
- Shutdown on init failure.
…t to stop calling submit_transfer. - Renamed cancelTransfers to endTransfers.
- Added grayscale test to see if crash after mic test in debayer code persists..
- Added some comments. - Improved shutdown in case of error. - Use libusb error/success codes instead of comparing against 0. - Code cleanups and readability improvenents.
- Made a few constant 'static const int' versus a define.
…transfers has reached zero. - Bumped the packet size to 256 bytes, to avoid overflow conditions due to the device sending more data than we can store. - Added logging for the case where a transfer has ended while status is not COMPLETED.
…cts. - Bumped packet size (again).
- Drawing of the captured audio waveform is now faster. - Combined audio and video test. It works!
… it on screen. The summed channel effective does some pretty good noise reduction!
…during shutdown. It's illegal to free a transfer from within the transfer callback. Doing so can result in undefined behavior. From the docs of libusb_free_transfer, "It is not legal to free an active transfer (one which has been submitted and has not yet completed)." I've moved to free calls until after all transfers have finished.
…rying to debayer one row too many. It should run until height-2, as a single source row expands to two rows in the destination buffer. At the end the last row is already copied from the row at height-2 to height-1. Verified it works by visually inspecting the last row using a test app.
…' to stop the microphone USB transfers. When encountering an error submitting the new transfer, try a few times until it works. Macos sometimes returns a 'iso too old' result when trying to submit a transfer, which just means we need to transfer again using a more recent frame.
- Show little green/red circles to indicate PS3 eye and mic are up and running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small improvements I made while implementing a DirectShow filter based on this code. The RGB debayer function was extended to RGBA using a template so that two versions of the function are compiled. This was done with the idea that having a static number of channels may help the compiler optimize this function better and also it avoids having to check if the alpha channel should be set for every pixel.