Conversation
SimonDuToit
requested review from
Louay-Ben-nessir,
OmaymaMahjoub,
RuanJohn,
WiemKhlifi and
sash-a
as code owners
sash-a
requested changes
Mar 11, 2025
Collaborator
sash-a
left a comment
sash-a
left a comment
There was a problem hiding this comment.
Just 1 change and then a though that waiting for the rec-IQL PR may be easiest
* implemented * cleaning * pipeline streamline * update * pr suggestions * cleaning * cleaning * pin gymnasium version * requirements update * cleaning
* feat: inital iql * fix: concat of trajs from diffrent actors * fix: deadlock caused by deleting when buffer is full * fix: major changes to the ratelimiter configs and a separate buffer per acotr * docs: minor comment chnage * feat: changed file structer, removed the threadlifetime and made minor chanage * chore: pre-commit * chore: minor changes * feat: Blocking rate limiter & replay ratio param * chor: small changes * feat: commen shutdown function * chor: updated for rec_ippo --------- Co-authored-by: Sasha Abramowitz <[email protected]>
sash-a
requested changes
Mar 12, 2025
Louay-Ben-nessir
previously approved these changes
Mar 27, 2025
Contributor
Louay-Ben-nessir
left a comment
Louay-Ben-nessir
left a comment
There was a problem hiding this comment.
everything looks sound to me!
RuanJohn
approved these changes
Mar 28, 2025
Collaborator
RuanJohn
left a comment
RuanJohn
left a comment
There was a problem hiding this comment.
LGTM. Excellent work 🔥
SimonDuToit
added a commit
that referenced
this pull request
Mar 31, 2025
* implemented * cleaning * cleaning * cleaning * clean pipeline * pin gymnasium version * requirements update * cleaning * Feat: sebulba recurrent ippo (#1156) * implemented * cleaning * pipeline streamline * update * pr suggestions * cleaning * cleaning * pin gymnasium version * requirements update * cleaning * Feat Sebulba recurrent IQL (#1148) * feat: inital iql * fix: concat of trajs from diffrent actors * fix: deadlock caused by deleting when buffer is full * fix: major changes to the ratelimiter configs and a separate buffer per acotr * docs: minor comment chnage * feat: changed file structer, removed the threadlifetime and made minor chanage * chore: pre-commit * chore: minor changes * feat: Blocking rate limiter & replay ratio param * chor: small changes * feat: commen shutdown function * chor: updated for rec_ippo --------- Co-authored-by: Sasha Abramowitz <[email protected]> * thread stopping update * cleaning * gym obs spec * obs space fix * obs dict key rename * iql fix * cleaning --------- Co-authored-by: Louay Ben nessir <[email protected]> Co-authored-by: Sasha Abramowitz <[email protected]>
SimonDuToit
added a commit
that referenced
this pull request
Apr 4, 2025
* implemented * cleaning * pr suggestions * cleaning * clean pipeline * gymnasium pin version * requirement fix * try update jax * requirements update * cleaning * updates from other ppos * Feat: ff sable Sebulba (#1157) * feat: ff sable sebulba * chor: pre-commits * feat: update sable * chor: abs metric message * chor: comment chnage * exp: eval n_devices and minor changes * chor: tiny change * chor: comment change * fix: update ff_sable * chor: pre-commits * chor: use ppo transition * chor: use ppo sebulba learnrer state * feat: feed forward sebulba MAPPO (#1161) * implemented * cleaning * cleaning * cleaning * clean pipeline * pin gymnasium version * requirements update * cleaning * Feat: sebulba recurrent ippo (#1156) * implemented * cleaning * pipeline streamline * update * pr suggestions * cleaning * cleaning * pin gymnasium version * requirements update * cleaning * Feat Sebulba recurrent IQL (#1148) * feat: inital iql * fix: concat of trajs from diffrent actors * fix: deadlock caused by deleting when buffer is full * fix: major changes to the ratelimiter configs and a separate buffer per acotr * docs: minor comment chnage * feat: changed file structer, removed the threadlifetime and made minor chanage * chore: pre-commit * chore: minor changes * feat: Blocking rate limiter & replay ratio param * chor: small changes * feat: commen shutdown function * chor: updated for rec_ippo --------- Co-authored-by: Sasha Abramowitz <[email protected]> * thread stopping update * cleaning * gym obs spec * obs space fix * obs dict key rename * iql fix * cleaning --------- Co-authored-by: Louay Ben nessir <[email protected]> Co-authored-by: Sasha Abramowitz <[email protected]> * update rec mappo, standardize init variable names * cleaning * cleaning * remove unnecessary type ignore --------- Co-authored-by: Louay Ben nessir <[email protected]> Co-authored-by: Sasha Abramowitz <[email protected]>
sash-a
pushed a commit
that referenced
this pull request
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.