Skip to content

feat: Kafka FUP Phase I #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Kafka FUP Phase I #718

wants to merge 2 commits into from

Conversation

CagriYonca
Copy link
Contributor

Changes:

  • The customers are able to use configuration.yaml file to filter specific services and methods now, as specified in the technical specification.
  • Specific topics and specific methods can be filtered using one of the below, configuration.yaml file has the highest priority, use send for kafka-python and produce for confluent-kafka:
    • os.environ["INSTANA_IGNORE_ENDPOINTS"] = "kafka:send,consume"
    • os.environ["INSTANA_IGNORE_ENDPOINTS"] = "kafka:produce,consume"
    • os.environ["INSTANA_IGNORE_ENDPOINTS"] = "kafka"
    • os.environ["INSTANA_IGNORE_ENDPOINTS_PATH"] = "configuration.yaml"

@CagriYonca CagriYonca self-assigned this Apr 10, 2025
@CagriYonca CagriYonca requested a review from a team as a code owner April 10, 2025 12:58
@CagriYonca CagriYonca force-pushed the ft/kafka-fup branch 7 times, most recently from e834b59 to 07cc254 Compare April 24, 2025 10:22
@CagriYonca CagriYonca requested review from pvital and GSVarsha April 24, 2025 10:46
@pvital
Copy link
Member

pvital commented Apr 29, 2025

@CagriYonca, please work on the #721 first, and after it is merged, we can finalize this one and the following one.

@pvital pvital added Do not merge Depends on another PR FUP labels Apr 29, 2025
@CagriYonca CagriYonca force-pushed the ft/kafka-fup branch 2 times, most recently from d8d36f2 to b79ab06 Compare May 7, 2025 07:55
@CagriYonca CagriYonca removed the Do not merge Depends on another PR label May 7, 2025
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests.
I am missing some tests for the new functions or environment variables to be parsed, as the INSTANA_IGNORE_ENDPOINTS_PATH.

@CagriYonca CagriYonca force-pushed the ft/kafka-fup branch 2 times, most recently from 634b521 to b01bf7a Compare May 8, 2025 10:33
@CagriYonca CagriYonca requested a review from pvital May 8, 2025 10:35
@CagriYonca CagriYonca force-pushed the ft/kafka-fup branch 5 times, most recently from 4bc4eb6 to e1383d4 Compare May 12, 2025 06:54
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants