-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Kafka FUP Phase I #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CagriYonca
wants to merge
2
commits into
main
Choose a base branch
from
ft/kafka-fup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+859
−328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSVarsha
reviewed
Apr 14, 2025
GSVarsha
reviewed
Apr 14, 2025
GSVarsha
reviewed
Apr 14, 2025
GSVarsha
reviewed
Apr 14, 2025
e834b59
to
07cc254
Compare
@CagriYonca, please work on the #721 first, and after it is merged, we can finalize this one and the following one. |
d8d36f2
to
b79ab06
Compare
pvital
requested changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few requests.
I am missing some tests for the new functions or environment variables to be parsed, as the INSTANA_IGNORE_ENDPOINTS_PATH
.
634b521
to
b01bf7a
Compare
4bc4eb6
to
e1383d4
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
configuration.yaml
file to filter specific services and methods now, as specified in the technical specification.configuration.yaml
file has the highest priority, usesend
for kafka-python andproduce
for confluent-kafka: