Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/296 add community pages #390

Merged

Conversation

marta-tomzik
Copy link
Contributor

  • added community pages with short description
  • exported hardware requirements to separate file and created links. When this is merged, the specs file will be linked in the main InstructLab repo.

@marta-tomzik marta-tomzik requested a review from a team as a code owner October 23, 2024 21:36
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Dec 23, 2024
Copy link
Member

@dominikkawka dominikkawka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late review, lgtm!

please sign the commits to let the DCO pass

@github-actions github-actions bot removed the stale label Jan 7, 2025
@jjasghar
Copy link
Member

Please fix the DCO, then we can merge this.

@marta-tomzik marta-tomzik force-pushed the feature/296-add-community-pages branch from 6d58688 to 1b5d800 Compare January 24, 2025 19:54
@marta-tomzik
Copy link
Contributor Author

fixed! :)

@jjasghar
Copy link
Member

jjasghar commented Feb 3, 2025

Please take a look at the checks, and fix the merge conflicts, you'll probably have to rebase :)

Signed-off-by: Marta Tomzik <[email protected]>
Signed-off-by: Marta Tomzik <[email protected]>
Signed-off-by: Marta Tomzik <[email protected]>
@marta-tomzik
Copy link
Contributor Author

@jjasghar @dominikkawka I've fixed everything, probably the spellcheck will fail again because of the service names that I used.

@dominikkawka dominikkawka merged commit 3720f1a into instructlab:main Mar 3, 2025
2 of 3 checks passed
@nathan-weinberg
Copy link
Member

@dominikkawka in the future, please have contributors add words to the dictionary instead of overriding CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants